Added backlight step functionality

keyboards/infinity60/led_controller.c

@@ -170,12 +170,12 @@ static THD_FUNCTION(LEDthread, arg) {
   (void)arg;
   chRegSetThreadName("LEDthread");
 
-  uint8_t i, page;
-  uint8_t control_register_word[2] = {0};
+  uint8_t i, j, page;
+  uint8_t control_register_word[2] = {0};//register address - byte to write
   uint8_t led_control_reg[0x13] = {0};//led control register start address + 0x12 bytes
 
   //persistent status variables
-  uint8_t backlight_status, led_step_status, layer_status;
+  uint8_t backlight_status, pwm_step_status, layer_status;
 
   //mailbox variables
   uint8_t temp, msg_type, msg_led;
@@ -187,9 +187,9 @@ static THD_FUNCTION(LEDthread, arg) {
 */
 
 // initialize persistent variables
-backlight_status = 0;
-led_step_status = 4; //full brightness
-layer_status = 0;
+backlight_status = 0; //start backlight off
+pwm_step_status = 4; //full brightness
+layer_status = 0; //start frame 0 (all off/on)
 
   while(true) {
     // wait for a message (asynchronous)
@@ -202,6 +202,7 @@ layer_status = 0;
     xprintf("--------------------\n");
     xprintf("mailbox fetch\nmsg: %X\n", msg);
     xprintf("type: %X - led: %X\n", msg_type, msg_led); //test if msg_type is 1 or 2 bytes after mask
+
     switch (msg_type){
       case KEY_LIGHT:
       //TODO: lighting key led on keypress
@@ -239,7 +240,7 @@ layer_status = 0;
 
       case TOGGLE_ALL:
       xprintf("TOGGLE_ALL\n");
-      //msg_led = unused, TODO: consider using msg_led to toggle layer display
+        //msg_led = unused
 
         is31_read_register(0, 0x00, &temp);//if first byte is on, then toggle frame 1 off
 
@@ -257,12 +258,10 @@ layer_status = 0;
           is31_write_register(IS31_FUNCTIONREG, IS31_REG_PICTDISP, 0);
         }
         layer_status=0;
-      //TODO: Double blink when all on
         break;
 
       case TOGGLE_BACKLIGHT:
         //msg_led = unused
-      //TODO: consider Frame 0 as on/off layer and toggle led control register here
         //TODO: need to test tracking of active layer with layer_state from qmk
       xprintf("TOGGLE_BACKLIGHT\n");
         backlight_status ^= 1;
@@ -273,9 +272,8 @@ layer_status = 0;
         is31_write_register(IS31_FUNCTIONREG, IS31_REG_PICTDISP, page);
         break;
 
-    case TOGGLE_LAYER_LEDS://show layer indicator or full map of layer keys.
-      //TODO: change so user can flag which they want, indiv or full map in fn_actions
-      //msg_led = layer to toggle on
+      case TOGGLE_PAGE_LEDS://show single layer indicator or full map of layer
+        //msg_led = page to toggle on
       xprintf("TOGGLE_LAYER_LEDS\n");
         is31_read_register(IS31_FUNCTIONREG, IS31_REG_PICTDISP, &temp);
 
@@ -290,43 +288,48 @@ layer_status = 0;
         
       case TOGGLE_NUM_LOCK:
         //msg_led = 0 or 1, off/on
-      //TODO: confirm toggling works and doesn't get out of sync
         set_lock_leds(USB_LED_NUM_LOCK, msg_led);
         break;
       
       case TOGGLE_CAPS_LOCK:
         //msg_led = 0 or 1, off/on
-      //TODO: confirm toggling works and doesn't get out of sync
         set_lock_leds(USB_LED_CAPS_LOCK, msg_led);
         break;
 
       case MODE_BREATH:
         break;
       case STEP_BRIGHTNESS:
-      //TEST: Step brightness code
+      xprintf("TOGGLE_BACKLIGHT\n");
+        //led_msg = step pwm up or down
+        //TODO: test step brightness code
         //pwm_levels[] bounds checking, loop through array
-      //TODO: find a cleaner way to walk through this logic
-      if (msg_led == 0 && led_step_status == 0) {
-        led_step_status = 4;
+      switch (msg_led) {
+        case 0:
+          if (pwm_step_status == 0) {
+            pwm_step_status = 4;
           } else {
-        led_step_status--;
+            pwm_step_status--;
           }
+          break;
         
-      if (msg_led == 1 && led_step_status == 4) {
-        led_step_status = 0;
+        case 1:
+          if (pwm_step_status == 4) {
+            pwm_step_status = 0;
           } else {
-        led_step_status++;
+            pwm_step_status++;
+          }
+          break;
       }
 
-      //TODO: this seems a messy way to populate the pwm register
-      //mimic whitefox init which uses memcpy
         //populate the 9 byte rows to be written to each pin, first byte is register (pin) address
-      for(i=1; i<9; i++) {
-        pwm_register_array[i]=pwm_levels[led_step_status]; 
-      }
+        __builtin_memset(pwm_register_array+1, pwm_levels[pwm_step_status], 8);
+
         for(i=0; i<8; i++) {
-        pwm_register_array[0] = 0x24 + (i * 0x10);//first byte of 9 bytes must be register address
-        is31_write_data(0, pwm_register_array, 9);//first page controls pwm in all pages (init Display Option register)
+        //first byte is register address, every 0x10 9 bytes is A-register pwm pins
+          pwm_register_array[0] = 0x24 + (i * 0x10);
+          for(j=0; j<9; j++) {
+          }
+          is31_write_data(0,pwm_register_array,9);
         }
       break;
 
@@ -360,11 +363,10 @@ layer_status = 0;
           // should not get here; wakeup should be received in the branch above break;
           break;
 */  
-    }
       xprintf("--------------------\n");
     }
   }
-
+}
 
 /* ==============================
  *    led processing functions
@@ -451,14 +453,14 @@ void set_lock_leds(uint8_t lock_type, uint8_t led_on) {
   }
 }
 
-void write_led_page (uint8_t page, const uint8_t *led_array, uint8_t led_count) {
+void write_led_page (uint8_t page, const uint8_t *user_led_array, uint8_t led_count) {
   uint8_t i;
   uint8_t row, col;
   uint8_t led_control_register[0x13] = {0};//led control register start address + 0x12 bytes
 
   for(i=0;i<led_count;i++){
-    row = ((led_array[i] / 10) % 10 - 1 ) * 2 + 1;//includes 1 byte shift for led register 0x00 address
-    col = led_array[i] % 10 - 1;
+    row = ((user_led_array[i] / 10) % 10 - 1 ) * 2 + 1;//includes 1 byte shift for led register 0x00 address
+    col = user_led_array[i] % 10 - 1;
     
     led_control_register[row] |= 1<<(col);
   }
@@ -491,22 +493,16 @@ void led_controller_init(void) {
   //set Display Option Register so all pwm intensity is controlled from Frame 1
   is31_write_register(IS31_FUNCTIONREG, IS31_REG_DISPLAYOPT, IS31_REG_DISPLAYOPT_INTENSITY_SAME);
 
+    //TODO: test new init pwm loop
   /* set full pwm on Frame 1 */
-  for(i=1; i<9; i++) {
-    pwm_register_array[i]=0xFF; 
-  }
+  pwm_register_array[0] = 0;
+  __builtin_memset(pwm_register_array+1, 0xFF, 8);
   for(i=0; i<8; i++) {
     pwm_register_array[0] = 0x24 + (i * 0x10);//first byte of 9 bytes must be register address
     is31_write_data(0, pwm_register_array, 9);
     chThdSleepMilliseconds(5);
   }
 
-  //set all led bits on for Frame 2 LEDS_ALL
-  //TODO: set all off in init
-  full_page[0] = 0;
-  __builtin_memset(full_page+1, 0, 0x12);
-  is31_write_data(1, full_page, 1+0x12);
-
   /* enable breathing when the displayed page changes */
   // Fade-in Fade-out, time = 26ms * 2^N, N=3
   is31_write_register(IS31_FUNCTIONREG, IS31_REG_BREATHCTRL1, (3<<4)|3);

keyboards/infinity60/led_controller.h

@@ -104,7 +104,7 @@ enum led_msg_t {
     TOGGLE_LED,
     TOGGLE_ALL,
     TOGGLE_BACKLIGHT,
-    TOGGLE_LAYER_LEDS,
+    TOGGLE_PAGE_LEDS,
     TOGGLE_NUM_LOCK,
     TOGGLE_CAPS_LOCK,
     MODE_BREATH,