From a13c5ebb7506d9a18d86e9884b6f579515a1f243 Mon Sep 17 00:00:00 2001
From: Jordan Orelli <jorelli@etsy.com>
Date: Thu, 7 Aug 2014 15:57:18 +0000
Subject: [PATCH] all values are []byte internally now

this might be a shitty idea.
---
 values.go | 23 +++++++++++------------
 1 file changed, 11 insertions(+), 12 deletions(-)

diff --git a/values.go b/values.go
index 45aa916..df7e99f 100644
--- a/values.go
+++ b/values.go
@@ -2,6 +2,7 @@ package main
 
 import (
 	"bufio"
+	"bytes"
 	"fmt"
 	"io"
 	"strconv"
@@ -189,10 +190,10 @@ func (s BulkString) Write(w io.Writer) (int, error) {
 
 // -----------------------------------------------------------------------------------------
 
-type Array []value
+type Array []byte
 
 func readArray(prefix []byte, r *bufio.Reader) (value, error) {
-	n, err := strconv.ParseInt(string(prefix), 10, 64)
+	n, err := strconv.Atoi(string(prefix))
 	if err != nil {
 		return nil, fmt.Errorf("unable to read array in redis protocol: bad prefix: %v", err)
 	}
@@ -204,23 +205,21 @@ func readArray(prefix []byte, r *bufio.Reader) (value, error) {
 		return nil, fmt.Errorf("redis protocol error: illegal array of negative length %d", n)
 	}
 
-	a := make(Array, n)
-	for i := int64(0); i < n; i++ {
+	buf := bytes.NewBuffer(make([]byte, 0, n*128))
+	buf.Write([]byte{'*'})
+	buf.Write([]byte(strconv.Itoa(n)))
+	buf.Write([]byte{'\r', '\n'})
+	for i := 0; i < n; i++ {
 		v, err := readValue(r)
 		if err != nil {
 			return nil, fmt.Errorf("unable to read array value in redis protocol: %v", err)
 		}
-		a[i] = v
+		v.Write(buf)
 	}
-	return a, nil
+	return Array(buf.Bytes()), nil
 }
 
 func (a Array) Write(w io.Writer) (int, error) {
-	w.Write([]byte{'*'})
-	w.Write([]byte(strconv.Itoa(len(a))))
-	w.Write([]byte{'\r', '\n'})
-	for i := 0; i < len(a); i++ {
-		a[i].Write(w)
-	}
+	w.Write(a)
 	return 0, nil
 }