You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
qmk_firmware/quantum
Gergely Nagy acda2b793f tap-dance: Do not start a sequence on keyup
There was an odd case, which confused the hell out of tap-dance: suppose
you had a number of tap-dance keys, on a layer, and as part of the
tap-dance, you turned that layer off - or had it on one-shot to begin
with. In this case, the keydown event would trigger the tap-dance key,
but the keyup would not. This had two funky consequences:

- tap-dance did not correctly register that the dance has ended.
- pressing any other tap-dance key would interrupt the previous
  tap-dance, and potentially input unwanted characters.

To fix this, we simply do not start a tap-dance sequence on keyup, only
when it is pressed. This way the previous sequence has enough time to
time-out and finish properly, and we don't get confused.

This fixes algernon/ergodox-layout#107.

Signed-off-by: Gergely Nagy <algernon@madhouse-project.org>
8 years ago
..
audio Add IN_LIKE_FLINT song 9 years ago
keymap_extras Removed unnecessary comment 8 years ago
process_keycode tap-dance: Do not start a sequence on keyup 8 years ago
serial_link Convert tirple_buffered_object_tests to GTest 8 years ago
template Fix the keyboard template with new make syntax 8 years ago
tools Backlight abstraction and other changes (#439) 9 years ago
visualizer Move the visualizer_user file to keymap folder 9 years ago
analog.c quantum separated 9 years ago
analog.h quantum separated 9 years ago
config_common.h Added pin support for A0-A7 8 years ago
dynamic_macro.h Implement the dynamic macros that are recorded in runtime 8 years ago
keycode_config.c Cleans up quantum/keymap situation, removes extra lufa folders (#416) 9 years ago
keycode_config.h Add ChibiOS support for QMK (#465) 9 years ago
keymap.h fix typo 8 years ago
keymap_common.c Fixes midi functionality 9 years ago
light_ws2812.c updates rgblight implementation, makes non-timer stuff compatible with audio 9 years ago
light_ws2812.h Integrate WS2812 code into quantum core 9 years ago
matrix.c fix/annotate wait_us lines 9 years ago
quantum.c Add a register/unregister_code16 pair of functions 8 years ago
quantum.h Add a register/unregister_code16 pair of functions 8 years ago
rgblight.c Simplify HSV->RGB calculation 9 years ago
rgblight.h updates rgblight implementation, makes non-timer stuff compatible with audio 9 years ago